PG-1437 Add a test for changing the keyring provider type #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutow
reviewed
Apr 4, 2025
|
Good point, and fixing that so we have the same key in two formats sounds quiet painful even for a TAP test. I will think on this and maybe withdraw it. |
jeltz
force-pushed
the
tde/provider-change-type-test
branch
from
1d18e5d to
29b07f0
Compare
Longterm we may want to allow this to prevent users from breaking stuff but for now we add a test to make it clear that changing the provider is currently allowed.
jeltz
force-pushed
the
tde/provider-change-type-test
branch
from
29b07f0 to
a18b586
Compare
|
I will close this PR and instead open a new one where I remove the TODOs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Longterm we may want to allow this to prevent users from breaking stuff but for now we add a test to make it clear that changing the provider is currently allowed.